Skip to content

Fix PEP-8 issues in contributing.rst #24003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 2, 2018
Merged

Fix PEP-8 issues in contributing.rst #24003

merged 3 commits into from
Dec 2, 2018

Conversation

FHaase
Copy link
Contributor

@FHaase FHaase commented Nov 29, 2018

No description provided.

FHaase
FHaase commented Nov 29, 2018
View reviewed changes
doc/source/contributing.rst
@@ -963,7 +970,7 @@ a single test.

.. code-block:: python

with warch.catch_warnings():
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume warnings was meant.
If someone knows better I can change it.

datapythonista
datapythonista approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @FHaase

I also think warnings was intended

@datapythonista datapythonista added Docs Code Style Code style, linting, code_checks labels Nov 29, 2018
@FHaase
Copy link
Contributor Author

FHaase commented Nov 30, 2018 

doc/source/contributing.rst:675:5: E302 expected 2 blank lines, found 1
doc/source/contributing.rst:684:5: E302 expected 2 blank lines, found 1

Requires #23847 before merging.

@datapythonista
Copy link
Member

@FHaase, I think you can merge master and leave the CI in green now.

Also, if you can remove the file from setup.cfg

@codecov
Copy link

codecov bot commented Dec 2, 2018 •
edited
Loading

Codecov Report

Merging #24003 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24003   +/-   ##
=======================================
  Coverage   42.45%   42.45%           
=======================================
  Files         161      161           
  Lines       51561    51561           
=======================================
  Hits        21888    21888           
  Misses      29673    29673
Flag Coverage Δ
#single 42.45% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/strings.py 33% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92d25f0...7d419e5. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 2, 2018 •
edited
Loading

Codecov Report

Merging #24003 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24003   +/-   ##
=======================================
  Coverage   42.45%   42.45%           
=======================================
  Files         161      161           
  Lines       51561    51561           
=======================================
  Hits        21888    21888           
  Misses      29673    29673
Flag Coverage Δ
#single 42.45% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/strings.py 33% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92d25f0...7d419e5. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Dec 2, 2018
@jreback jreback merged commit 45f880b into pandas-dev:master Dec 2, 2018
@jreback
Copy link
Contributor

jreback commented Dec 2, 2018

thanks @FHaase

@FHaase FHaase deleted the fix-pep8-contributing branch December 3, 2018 19:09
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@FHaase @Pingviinituutti
Fix PEP-8 issues in contributing.rst (pandas-dev#24003)
7510835
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@FHaase @Pingviinituutti
Fix PEP-8 issues in contributing.rst (pandas-dev#24003)
94bbed4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks Docs
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@FHaase @datapythonista @jreback